Issue Details (XML | Word | Printable)

Key: CODEBASE-170
Type: Bug Bug
Status: Resolved Resolved
Resolution: Won't Fix
Priority: Minor Minor
Assignee: Jessie Keck
Reporter: Richard Green
Votes: 0
Watchers: 1
Operations

Clone this issue
If you were logged in you would be able to see more operations.
Blacklight Plugin

Blacklight logo cannot be over-ridden

Created: 13/Aug/09 05:12 AM   Updated: 23/Oct/09 12:42 PM
Component/s: None
Affects Version/s: 2.3
Fix Version/s: 2.4

Environment: Red Hat Linux


 Description  « Hide
In 2.3 the pretty 'Blacklight' logo comes from /blacklight/rails/public/plugin_assets/blacklight/images/logo.png This is not over-ridden by a local logo at /blacklight/rails/public/images/logo.png. Further if the Blacklight logo is replaced in the plugin_assets structure with a local one this gets over-written at each restart.

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Naomi Dushay added a comment - 25/Sep/09 12:45 PM
Jessie -

Do we have this problem? If not, can you document how to avoid Richard's issue in the appropriate README, and/or fix it in the plugin?

Jessie Keck added a comment - 02/Oct/09 05:50 PM
The engines infrastructure doesn't really accommodate overriding images, stylesheets, or javascripts. It's main focus is on modules, classes, methods, and views. We have our own visual design so we just have or own logo in the public/images directory and point to that logo in our _header.html.erb partial. The main problem is that the person creating the app could technically create any number of directories called whatever they want under public to house their images. So we can't necessarily guarantee the exact location of an image. If anybody wants this in the plugin I would be more than happy to write in the facility as long as there was an agreed upon location for this image. I just don't know if the rest of the community wants to get this granular with the visual design in respects to other top priorities.

Also, this is correct that every time the app is restarted the plugin assests are reloaded. This is so that if anything changes in the plugin, it will be brought up to the app level on the subsequent restart.

Bess Sadler added a comment - 23/Oct/09 12:42 PM
This feels out of scope. We'll address this in the customizing your local version docs.