Blacklight Plugin

Change template jetty install to put jetty somewhere else

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: None
  • Fix Version/s: 2.6
  • Component/s: None
  • Description:
    Hide
    Currently, if you use the template installer, and ask it to install jetty for you, it puts it inside the blacklight plugin:

    your_app/vendor/plugins/blacklight/jetty

    I see two problems with this.

    1) I think an expected use case for this installed jetty is that the local maintainer will begin modifying it to meet their needs. However, if they do so, and later update their blacklight plugin -- that jetty can easily be lost, depending on how they do the upgrade. In general, I don't think we should encouraging any localized stuff to be in the blacklight plugin directory, it should remain pristine, so it can be upgraded simply by replacing the whole directory.

    2) That is the same location that "git submodule update" will try to put the 'test' jetty for running tests against, and that the BL tests will expect a test jetty to be. But I could see easily wanting both a test jetty (entirely unmodified, goes with the version/snapshot of BL you have, matching it's tests), AND wanting a sample jetty to get started customizing for my actual app. They ought not to be expected to be in the same place.

    Proposal:

    Change the template installer to put the optional jetty install at your own app's RAILS_ROOT/jetty . Change any built-in default config to expect jetty for production and development to by default be at that location. (jetty for test remains where it is).


    Any downsides to this? Please comment with concerns or support or opinions in this ticket. If I get no comments, I'll assume everyone's okay with it, and do it!
    Show
    Currently, if you use the template installer, and ask it to install jetty for you, it puts it inside the blacklight plugin: your_app/vendor/plugins/blacklight/jetty I see two problems with this. 1) I think an expected use case for this installed jetty is that the local maintainer will begin modifying it to meet their needs. However, if they do so, and later update their blacklight plugin -- that jetty can easily be lost, depending on how they do the upgrade. In general, I don't think we should encouraging any localized stuff to be in the blacklight plugin directory, it should remain pristine, so it can be upgraded simply by replacing the whole directory. 2) That is the same location that "git submodule update" will try to put the 'test' jetty for running tests against, and that the BL tests will expect a test jetty to be. But I could see easily wanting both a test jetty (entirely unmodified, goes with the version/snapshot of BL you have, matching it's tests), AND wanting a sample jetty to get started customizing for my actual app. They ought not to be expected to be in the same place. Proposal: Change the template installer to put the optional jetty install at your own app's RAILS_ROOT/jetty . Change any built-in default config to expect jetty for production and development to by default be at that location. (jetty for test remains where it is). Any downsides to this? Please comment with concerns or support or opinions in this ticket. If I get no comments, I'll assume everyone's okay with it, and do it!

Activity

Hide
Jonathan Rochkind added a comment - 04/May/10 11:23 AM
Nevermind, I think I'm completely wrong about what it does! Investigating further.
Show
Jonathan Rochkind added a comment - 04/May/10 11:23 AM Nevermind, I think I'm completely wrong about what it does! Investigating further.
Hide
Jonathan Rochkind added a comment - 04/May/10 11:30 AM
I was completely wrong, it already does what I say!
Show
Jonathan Rochkind added a comment - 04/May/10 11:30 AM I was completely wrong, it already does what I say!

People

Dates

  • Created:
    04/May/10 11:21 AM
    Updated:
    04/May/10 11:30 AM
    Resolved:
    04/May/10 11:30 AM