Blacklight Plugin

Fix facet limit functionality to not require sending lots of params to solr

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.6
  • Component/s: None
  • Description:
    Hide
    The current facet limit functionality in Blacklight results in a facet.limit value being sent in every solr search request, one for each configured facet limit. This is to ensure that the right number of facet values is returned by Solr, for facet limiting functionality to work. (Recall that facet limiting requires solr to return n+1 values, in order to display page sizes of n values).

    This works, but results in a messy solr query that is confusing to look at in your logs and debugging and such.

    This functionality should be left, but the facet limit funcitonality shoudl be changed so you can configure it to "true" instead of a number, which will tell Blacklight, for this facet, if the solr facet.limit was set to N by solr defaults, then page at N-1 per page.
    Show
    The current facet limit functionality in Blacklight results in a facet.limit value being sent in every solr search request, one for each configured facet limit. This is to ensure that the right number of facet values is returned by Solr, for facet limiting functionality to work. (Recall that facet limiting requires solr to return n+1 values, in order to display page sizes of n values). This works, but results in a messy solr query that is confusing to look at in your logs and debugging and such. This functionality should be left, but the facet limit funcitonality shoudl be changed so you can configure it to "true" instead of a number, which will tell Blacklight, for this facet, if the solr facet.limit was set to N by solr defaults, then page at N-1 per page.

Issue Links

pre-requisite
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan Rochkind added a comment - 23/Aug/10 2:39 PM
Done, dove-tailed nicely with CODEBASE-244.

Set your facet limit config values to 'true', they'll take their pagination limits from echo'd facet.limit solr request parameters, set for instance in the :default_solr_params from CODEBASE-244 (or set in Solr request handler defaults, if you echoParams=all so the Rails code can see em).

No longer a way to configure 'default' limit with facet limit config alone, instead you can set a facet.limit=x in default_solr_params, and set all your facet limits to 'true'.

Makes it possible and easier to have cleaner solr requests for facet limits.
Show
Jonathan Rochkind added a comment - 23/Aug/10 2:39 PM Done, dove-tailed nicely with CODEBASE-244. Set your facet limit config values to 'true', they'll take their pagination limits from echo'd facet.limit solr request parameters, set for instance in the :default_solr_params from CODEBASE-244 (or set in Solr request handler defaults, if you echoParams=all so the Rails code can see em). No longer a way to configure 'default' limit with facet limit config alone, instead you can set a facet.limit=x in default_solr_params, and set all your facet limits to 'true'. Makes it possible and easier to have cleaner solr requests for facet limits.

People

Dates

  • Created:
    16/Jun/10 12:22 PM
    Updated:
    23/Aug/10 2:39 PM
    Resolved:
    23/Aug/10 2:39 PM
Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Blacklight. Try JIRA - bug tracking software for your team.