Blacklight Plugin

Ruby 1.9: utf-8 in test helpers

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.6
  • Component/s: None
  • Description:
    Hide
    In Ruby 1.9, certain magic around character encoding detection was removed, which requires files to explicitly declare encodings (by putting "# encoding: UTF-8" at the head of all problem files). As yet, this only is a problem for four spec files:

    spec/lib/blacklight_marc_spec.rb
    spec/lib/marc_citation_spec.rb
    spec/models/record_mailer_spec.rb
    spec/models/solr_document_spec.rb
    Show
    In Ruby 1.9, certain magic around character encoding detection was removed, which requires files to explicitly declare encodings (by putting "# encoding: UTF-8" at the head of all problem files). As yet, this only is a problem for four spec files: spec/lib/blacklight_marc_spec.rb spec/lib/marc_citation_spec.rb spec/models/record_mailer_spec.rb spec/models/solr_document_spec.rb

Issue Links

Activity

Hide
Chris Beer added a comment - 27/Jul/10 1:29 PM
Fixed in commit 9e687e221f36affdcd593329cf9a19b608a22892 by adding appropriate declarations in the above files. Maybe there is a bigger policy issue surrounding this, however it can be solved ad-hoc for now.
Show
Chris Beer added a comment - 27/Jul/10 1:29 PM Fixed in commit 9e687e221f36affdcd593329cf9a19b608a22892 by adding appropriate declarations in the above files. Maybe there is a bigger policy issue surrounding this, however it can be solved ad-hoc for now.

People

Dates

  • Created:
    27/Jul/10 1:22 PM
    Updated:
    27/Jul/10 1:29 PM
    Resolved:
    27/Jul/10 1:29 PM